deadcade/Ryujinx
1
0
Fork 0
Code Issues Pull requests Projects Releases Packages Wiki Activity

Fix GDB server crashes

Browse source
This commit is contained in:
svc64 2023-11-11 17:08:25 +02:00
parent e3b8060417
commit 1684a9d7a2
2 changed files with 39 additions and 49 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

56
src/Ryujinx.HLE/Debugger/Debugger.cs
View file

@ -27,8 +27,7 @@ namespace Ryujinx.HLE.Debugger
private NetworkStream ReadStream = null;
private NetworkStream WriteStream = null;
private BlockingCollection<IMessage> Messages = new BlockingCollection<IMessage>(1);
private Thread SocketThread;
private Thread HandlerThread;
private Thread DebuggerThread;
private bool _shuttingDown = false;
private ulong? cThread;
@ -41,10 +40,8 @@ namespace Ryujinx.HLE.Debugger
ARMeilleure.Optimizations.EnableDebugging = true;
SocketThread = new Thread(SocketReaderThreadMain);
HandlerThread = new Thread(HandlerThreadMain);
SocketThread.Start();
HandlerThread.Start();
DebuggerThread = new Thread(DebuggerThreadMain);
DebuggerThread.Start();
}
private IDebuggableProcess DebugProcess => Device.System.DebugGetApplicationProcess();
@ -144,21 +141,16 @@ namespace Ryujinx.HLE.Debugger
}
}
private void HandlerThreadMain()
private void HandleMessage(IMessage msg)
{
while (true)
switch (msg)
{
switch (Messages.Take())
{
case AbortMessage _:
return;
case BreakInMessage _:
case BreakInMessage:
Logger.Notice.Print(LogClass.GdbStub, "Break-in requested");
CommandQuery();
break;
case SendNackMessage _:
case SendNackMessage:
WriteStream.WriteByte((byte)'-');
break;
@ -168,13 +160,12 @@ namespace Ryujinx.HLE.Debugger
ProcessCommand(cmd);
break;
case ThreadBreakMessage msg:
case ThreadBreakMessage {Context: var ctx}:
DebugProcess.DebugStop();
Reply($"T05thread:{msg.Context.ThreadUid:x};");
Reply($"T05thread:{ctx.ThreadUid:x};");
break;
}
}
}
private void ProcessCommand(string cmd)
{
@ -595,15 +586,23 @@ namespace Ryujinx.HLE.Debugger
Reply("E01");
}
private void SocketReaderThreadMain()
private void DebuggerThreadMain()
{
var endpoint = new IPEndPoint(IPAddress.Any, GdbStubPort);
ListenerSocket = new TcpListener(endpoint);
ListenerSocket.Start();
Logger.Notice.Print(LogClass.GdbStub, $"Currently waiting on {endpoint} for GDB client");
while (true) {
while (!_shuttingDown)
{
try
{
ClientSocket = ListenerSocket.AcceptSocket();
}
catch (SocketException)
{
return;
}
ClientSocket.NoDelay = true;
ReadStream = new NetworkStream(ClientSocket, System.IO.FileAccess.Read);
WriteStream = new NetworkStream(ClientSocket, System.IO.FileAccess.Write);
@ -623,7 +622,7 @@ namespace Ryujinx.HLE.Debugger
Logger.Notice.Print(LogClass.GdbStub, "NACK received!");
continue;
case '\x03':
Messages.Add(new BreakInMessage());
HandleMessage(new BreakInMessage());
break;
case '$':
string cmd = "";
@ -640,11 +639,11 @@ namespace Ryujinx.HLE.Debugger
string checksum = $"{(char)ReadStream.ReadByte()}{(char)ReadStream.ReadByte()}";
if (checksum == $"{CalculateChecksum(cmd):x2}")
{
Messages.Add(new CommandMessage(cmd));
HandleMessage(new CommandMessage(cmd));
}
else
{
Messages.Add(new SendNackMessage());
HandleMessage(new SendNackMessage());
}
break;
@ -659,8 +658,11 @@ namespace Ryujinx.HLE.Debugger
eof:
Logger.Notice.Print(LogClass.GdbStub, "GDB client lost connection");
ReadStream.Close();
ReadStream = null;
WriteStream.Close();
WriteStream = null;
ClientSocket.Close();
ClientSocket = null;
}
}
@ -718,18 +720,12 @@ namespace Ryujinx.HLE.Debugger
{
_shuttingDown = true;
if (HandlerThread.IsAlive)
{
Messages.Add(new AbortMessage());
}
ListenerSocket.Stop();
ClientSocket?.Shutdown(SocketShutdown.Both);
ClientSocket?.Close();
ReadStream?.Close();
WriteStream?.Close();
SocketThread.Join();
HandlerThread.Join();
DebuggerThread.Join();
}
}

6
src/Ryujinx.HLE/Debugger/Message/AbortMessage.cs
View file

@ -1,6 +0,0 @@
namespace Ryujinx.HLE.Debugger
{
struct AbortMessage : IMessage
{
}
}