a7c6e6a8cf
Command buffer errors currently trigger an exception "DeviceLost" crashing the process.
Looking at [MKV's code](53a4eb26f2/MoltenVK/MoltenVK/GPUObjects/MVKQueue.mm (L392-L408)) we observe that:
- It hard fails if error is:
```
MTLCommandBufferErrorBlacklisted || MTLCommandBufferErrorNotPermitted || MTLCommandBufferErrorDeviceRemoved
```
- Otherwise fails conditionally if `config.resumeLostDevice == false` (current default)
For Ryujinx's use-case it's more graceful to resume on those errors rather than crashing the app, the error isn't totally silenced since `mvk` still logs it
Fixes #4704, #4575
33 lines
No EOL
1.2 KiB
C#
33 lines
No EOL
1.2 KiB
C#
using Silk.NET.Vulkan;
|
|
using System;
|
|
using System.Runtime.InteropServices;
|
|
using System.Runtime.Versioning;
|
|
|
|
namespace Ryujinx.Graphics.Vulkan.MoltenVK
|
|
{
|
|
[SupportedOSPlatform("macos")]
|
|
public static partial class MVKInitialization
|
|
{
|
|
[LibraryImport("libMoltenVK.dylib")]
|
|
private static partial Result vkGetMoltenVKConfigurationMVK(IntPtr unusedInstance, out MVKConfiguration config, in IntPtr configSize);
|
|
|
|
[LibraryImport("libMoltenVK.dylib")]
|
|
private static partial Result vkSetMoltenVKConfigurationMVK(IntPtr unusedInstance, in MVKConfiguration config, in IntPtr configSize);
|
|
|
|
public static void Initialize()
|
|
{
|
|
var configSize = (IntPtr)Marshal.SizeOf<MVKConfiguration>();
|
|
|
|
vkGetMoltenVKConfigurationMVK(IntPtr.Zero, out MVKConfiguration config, configSize);
|
|
|
|
config.UseMetalArgumentBuffers = true;
|
|
|
|
config.SemaphoreSupportStyle = MVKVkSemaphoreSupportStyle.MVK_CONFIG_VK_SEMAPHORE_SUPPORT_STYLE_SINGLE_QUEUE;
|
|
config.SynchronousQueueSubmits = false;
|
|
|
|
config.ResumeLostDevice = true;
|
|
|
|
vkSetMoltenVKConfigurationMVK(IntPtr.Zero, config, configSize);
|
|
}
|
|
}
|
|
} |