ca59c3f499
* Vulkan: Feedback loop improvements This PR allows the Vulkan backend to detect attachment feedback loops. These are currently used in the following ways: - Partial use of VK_EXT_attachment_feedback_loop_layout - All renderable textures have AttachmentFeedbackLoopBitExt - Compile pipelines with Color/DepthStencil feedback loop flags when present - Support using FragmentBarrier for feedback loops (fixes regressions from https://github.com/Ryujinx/Ryujinx/pull/7012 ) TODO: - AMD GPUs may need layout transitions for it to properly allow textures to be used in feedback loops. - Use dynamic state for feedback loops. The background pipeline will always miss since feedback loop state isn't known on the GPU project. - How is the barrier dependency flag used? (DXVK just ignores it, there's no vulkan validation...) - Improve subpass dependencies to fix validation errors * Mark field readonly * Add feedback loop dynamic state * fix: add MoltenVK resolver workaround fix: add MoltenVK resolver workaround * Formatting * Fix more complaints * RADV dcc workaround * Use dynamic state properly, cleanup. * Use aspects flags in more places
344 lines
11 KiB
C#
344 lines
11 KiB
C#
using Ryujinx.Graphics.GAL;
|
|
using Silk.NET.Vulkan;
|
|
using System;
|
|
using System.Linq;
|
|
using VkFormat = Silk.NET.Vulkan.Format;
|
|
|
|
namespace Ryujinx.Graphics.Vulkan
|
|
{
|
|
class FramebufferParams
|
|
{
|
|
private readonly Device _device;
|
|
private readonly Auto<DisposableImageView>[] _attachments;
|
|
private readonly TextureView[] _colors;
|
|
private readonly TextureView _depthStencil;
|
|
private readonly TextureView[] _colorsCanonical;
|
|
private readonly TextureView _baseAttachment;
|
|
private readonly uint _validColorAttachments;
|
|
|
|
public uint Width { get; }
|
|
public uint Height { get; }
|
|
public uint Layers { get; }
|
|
|
|
public uint[] AttachmentSamples { get; }
|
|
public VkFormat[] AttachmentFormats { get; }
|
|
public int[] AttachmentIndices { get; }
|
|
public uint AttachmentIntegerFormatMask { get; }
|
|
public bool LogicOpsAllowed { get; }
|
|
|
|
public int AttachmentsCount { get; }
|
|
public int MaxColorAttachmentIndex => AttachmentIndices.Length > 0 ? AttachmentIndices[^1] : -1;
|
|
public bool HasDepthStencil { get; }
|
|
public int ColorAttachmentsCount => AttachmentsCount - (HasDepthStencil ? 1 : 0);
|
|
|
|
public FramebufferParams(Device device, TextureView view, uint width, uint height)
|
|
{
|
|
var format = view.Info.Format;
|
|
|
|
bool isDepthStencil = format.IsDepthOrStencil();
|
|
|
|
_device = device;
|
|
_attachments = new[] { view.GetImageViewForAttachment() };
|
|
_validColorAttachments = isDepthStencil ? 0u : 1u;
|
|
_baseAttachment = view;
|
|
|
|
if (isDepthStencil)
|
|
{
|
|
_depthStencil = view;
|
|
}
|
|
else
|
|
{
|
|
_colors = new TextureView[] { view };
|
|
_colorsCanonical = _colors;
|
|
}
|
|
|
|
Width = width;
|
|
Height = height;
|
|
Layers = 1;
|
|
|
|
AttachmentSamples = new[] { (uint)view.Info.Samples };
|
|
AttachmentFormats = new[] { view.VkFormat };
|
|
AttachmentIndices = isDepthStencil ? Array.Empty<int>() : new[] { 0 };
|
|
AttachmentIntegerFormatMask = format.IsInteger() ? 1u : 0u;
|
|
LogicOpsAllowed = !format.IsFloatOrSrgb();
|
|
|
|
AttachmentsCount = 1;
|
|
|
|
HasDepthStencil = isDepthStencil;
|
|
}
|
|
|
|
public FramebufferParams(Device device, ITexture[] colors, ITexture depthStencil)
|
|
{
|
|
_device = device;
|
|
|
|
int colorsCount = colors.Count(IsValidTextureView);
|
|
|
|
int count = colorsCount + (IsValidTextureView(depthStencil) ? 1 : 0);
|
|
|
|
_attachments = new Auto<DisposableImageView>[count];
|
|
_colors = new TextureView[colorsCount];
|
|
_colorsCanonical = colors.Select(color => color is TextureView view && view.Valid ? view : null).ToArray();
|
|
|
|
AttachmentSamples = new uint[count];
|
|
AttachmentFormats = new VkFormat[count];
|
|
AttachmentIndices = new int[colorsCount];
|
|
|
|
uint width = uint.MaxValue;
|
|
uint height = uint.MaxValue;
|
|
uint layers = uint.MaxValue;
|
|
|
|
int index = 0;
|
|
int bindIndex = 0;
|
|
uint attachmentIntegerFormatMask = 0;
|
|
bool allFormatsFloatOrSrgb = colorsCount != 0;
|
|
|
|
foreach (ITexture color in colors)
|
|
{
|
|
if (IsValidTextureView(color))
|
|
{
|
|
var texture = (TextureView)color;
|
|
|
|
_attachments[index] = texture.GetImageViewForAttachment();
|
|
_colors[index] = texture;
|
|
_validColorAttachments |= 1u << bindIndex;
|
|
_baseAttachment = texture;
|
|
|
|
AttachmentSamples[index] = (uint)texture.Info.Samples;
|
|
AttachmentFormats[index] = texture.VkFormat;
|
|
AttachmentIndices[index] = bindIndex;
|
|
|
|
var format = texture.Info.Format;
|
|
|
|
if (format.IsInteger())
|
|
{
|
|
attachmentIntegerFormatMask |= 1u << bindIndex;
|
|
}
|
|
|
|
allFormatsFloatOrSrgb &= format.IsFloatOrSrgb();
|
|
|
|
width = Math.Min(width, (uint)texture.Width);
|
|
height = Math.Min(height, (uint)texture.Height);
|
|
layers = Math.Min(layers, (uint)texture.Layers);
|
|
|
|
if (++index >= colorsCount)
|
|
{
|
|
break;
|
|
}
|
|
}
|
|
|
|
bindIndex++;
|
|
}
|
|
|
|
AttachmentIntegerFormatMask = attachmentIntegerFormatMask;
|
|
LogicOpsAllowed = !allFormatsFloatOrSrgb;
|
|
|
|
if (depthStencil is TextureView dsTexture && dsTexture.Valid)
|
|
{
|
|
_attachments[count - 1] = dsTexture.GetImageViewForAttachment();
|
|
_depthStencil = dsTexture;
|
|
_baseAttachment ??= dsTexture;
|
|
|
|
AttachmentSamples[count - 1] = (uint)dsTexture.Info.Samples;
|
|
AttachmentFormats[count - 1] = dsTexture.VkFormat;
|
|
|
|
width = Math.Min(width, (uint)dsTexture.Width);
|
|
height = Math.Min(height, (uint)dsTexture.Height);
|
|
layers = Math.Min(layers, (uint)dsTexture.Layers);
|
|
|
|
HasDepthStencil = true;
|
|
}
|
|
|
|
if (count == 0)
|
|
{
|
|
width = height = layers = 1;
|
|
}
|
|
|
|
Width = width;
|
|
Height = height;
|
|
Layers = layers;
|
|
|
|
AttachmentsCount = count;
|
|
}
|
|
|
|
public Auto<DisposableImageView> GetAttachment(int index)
|
|
{
|
|
if ((uint)index >= _attachments.Length)
|
|
{
|
|
return null;
|
|
}
|
|
|
|
return _attachments[index];
|
|
}
|
|
|
|
public Auto<DisposableImageView> GetDepthStencilAttachment()
|
|
{
|
|
if (!HasDepthStencil)
|
|
{
|
|
return null;
|
|
}
|
|
|
|
return _attachments[AttachmentsCount - 1];
|
|
}
|
|
|
|
public ComponentType GetAttachmentComponentType(int index)
|
|
{
|
|
if (_colors != null && (uint)index < _colors.Length)
|
|
{
|
|
var format = _colors[index].Info.Format;
|
|
|
|
if (format.IsSint())
|
|
{
|
|
return ComponentType.SignedInteger;
|
|
}
|
|
|
|
if (format.IsUint())
|
|
{
|
|
return ComponentType.UnsignedInteger;
|
|
}
|
|
}
|
|
|
|
return ComponentType.Float;
|
|
}
|
|
|
|
public ImageAspectFlags GetDepthStencilAspectFlags()
|
|
{
|
|
if (_depthStencil == null)
|
|
{
|
|
return ImageAspectFlags.None;
|
|
}
|
|
|
|
return _depthStencil.Info.Format.ConvertAspectFlags();
|
|
}
|
|
|
|
public bool IsValidColorAttachment(int bindIndex)
|
|
{
|
|
return (uint)bindIndex < Constants.MaxRenderTargets && (_validColorAttachments & (1u << bindIndex)) != 0;
|
|
}
|
|
|
|
private static bool IsValidTextureView(ITexture texture)
|
|
{
|
|
return texture is TextureView view && view.Valid;
|
|
}
|
|
|
|
public ClearRect GetClearRect(Rectangle<int> scissor, int layer, int layerCount)
|
|
{
|
|
int x = scissor.X;
|
|
int y = scissor.Y;
|
|
int width = Math.Min((int)Width - scissor.X, scissor.Width);
|
|
int height = Math.Min((int)Height - scissor.Y, scissor.Height);
|
|
|
|
return new ClearRect(new Rect2D(new Offset2D(x, y), new Extent2D((uint)width, (uint)height)), (uint)layer, (uint)layerCount);
|
|
}
|
|
|
|
public unsafe Auto<DisposableFramebuffer> Create(Vk api, CommandBufferScoped cbs, Auto<DisposableRenderPass> renderPass)
|
|
{
|
|
ImageView* attachments = stackalloc ImageView[_attachments.Length];
|
|
|
|
for (int i = 0; i < _attachments.Length; i++)
|
|
{
|
|
attachments[i] = _attachments[i].Get(cbs).Value;
|
|
}
|
|
|
|
var framebufferCreateInfo = new FramebufferCreateInfo
|
|
{
|
|
SType = StructureType.FramebufferCreateInfo,
|
|
RenderPass = renderPass.Get(cbs).Value,
|
|
AttachmentCount = (uint)_attachments.Length,
|
|
PAttachments = attachments,
|
|
Width = Width,
|
|
Height = Height,
|
|
Layers = Layers,
|
|
};
|
|
|
|
api.CreateFramebuffer(_device, in framebufferCreateInfo, null, out var framebuffer).ThrowOnError();
|
|
return new Auto<DisposableFramebuffer>(new DisposableFramebuffer(api, _device, framebuffer), null, _attachments);
|
|
}
|
|
|
|
public TextureView[] GetAttachmentViews()
|
|
{
|
|
var result = new TextureView[_attachments.Length];
|
|
|
|
_colors?.CopyTo(result, 0);
|
|
|
|
if (_depthStencil != null)
|
|
{
|
|
result[^1] = _depthStencil;
|
|
}
|
|
|
|
return result;
|
|
}
|
|
|
|
public RenderPassCacheKey GetRenderPassCacheKey()
|
|
{
|
|
return new RenderPassCacheKey(_depthStencil, _colorsCanonical);
|
|
}
|
|
|
|
public void InsertLoadOpBarriers(VulkanRenderer gd, CommandBufferScoped cbs)
|
|
{
|
|
if (_colors != null)
|
|
{
|
|
foreach (var color in _colors)
|
|
{
|
|
// If Clear or DontCare were used, this would need to be write bit.
|
|
color.Storage?.QueueLoadOpBarrier(cbs, false);
|
|
}
|
|
}
|
|
|
|
_depthStencil?.Storage?.QueueLoadOpBarrier(cbs, true);
|
|
|
|
gd.Barriers.Flush(cbs, false, null, null);
|
|
}
|
|
|
|
public void AddStoreOpUsage()
|
|
{
|
|
if (_colors != null)
|
|
{
|
|
foreach (var color in _colors)
|
|
{
|
|
color.Storage?.AddStoreOpUsage(false);
|
|
}
|
|
}
|
|
|
|
_depthStencil?.Storage?.AddStoreOpUsage(true);
|
|
}
|
|
|
|
public void ClearBindings()
|
|
{
|
|
_depthStencil?.Storage.ClearBindings();
|
|
|
|
for (int i = 0; i < _colorsCanonical.Length; i++)
|
|
{
|
|
_colorsCanonical[i]?.Storage.ClearBindings();
|
|
}
|
|
}
|
|
|
|
public void AddBindings()
|
|
{
|
|
_depthStencil?.Storage.AddBinding(_depthStencil);
|
|
|
|
for (int i = 0; i < _colorsCanonical.Length; i++)
|
|
{
|
|
TextureView color = _colorsCanonical[i];
|
|
color?.Storage.AddBinding(color);
|
|
}
|
|
}
|
|
|
|
public (RenderPassHolder rpHolder, Auto<DisposableFramebuffer> framebuffer) GetPassAndFramebuffer(
|
|
VulkanRenderer gd,
|
|
Device device,
|
|
CommandBufferScoped cbs)
|
|
{
|
|
return _baseAttachment.GetPassAndFramebuffer(gd, device, cbs, this);
|
|
}
|
|
|
|
public TextureView GetColorView(int index)
|
|
{
|
|
return _colorsCanonical[index];
|
|
}
|
|
|
|
public TextureView GetDepthStencilView()
|
|
{
|
|
return _depthStencil;
|
|
}
|
|
}
|
|
}
|